Don't consider unstable fields always-inhabited #144216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Nadrieril
force-pushed
the
revert-pin-hack
branch
from
41ea610 to
be73c90
Compare
lqd
reviewed
Jul 20, 2025
This comment has been minimized.
This comment has been minimized.
This reverts the hack in rust-lang#133889 now that `Pin`'s field is no longer public.
Nadrieril
force-pushed
the
revert-pin-hack
branch
from
be73c90 to
3567ab1
Compare
compiler-errors
approved these changes
Jul 20, 2025
|
@bors r=compiler-errors rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 20, 2025
…ler-errors Don't consider unstable fields always-inhabited This reverts the hack in rust-lang#133889 now that `Pin`'s field is no longer public. Fixes rust-lang#143468. r? `@compiler-errors`
bors
added a commit
that referenced
this pull request
Jul 20, 2025
Rollup of 7 pull requests Successful merges: - #142097 (gpu offload host code generation) - #143906 (Miri: non-deterministic floating point operations in `foreign_items`) - #144144 (tests: Skip supported-crate-types test on musl hosts) - #144159 (opt-dist: change build_dir field to be an actual build dir) - #144162 (Debug impls for DropElaborators) - #144189 (Add non-regression test for #144168) - #144216 (Don't consider unstable fields always-inhabited) r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 20, 2025
…ler-errors Don't consider unstable fields always-inhabited This reverts the hack in rust-lang#133889 now that `Pin`'s field is no longer public. Fixes rust-lang#143468. r? ``@compiler-errors``
bors
added a commit
that referenced
this pull request
Jul 21, 2025
Rollup of 6 pull requests Successful merges: - #142097 (gpu offload host code generation) - #143906 (Miri: non-deterministic floating point operations in `foreign_items`) - #144144 (tests: Skip supported-crate-types test on musl hosts) - #144162 (Debug impls for DropElaborators) - #144189 (Add non-regression test for #144168) - #144216 (Don't consider unstable fields always-inhabited) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jul 21, 2025
Rollup of 8 pull requests Successful merges: - #144144 (tests: Skip supported-crate-types test on musl hosts) - #144159 (opt-dist: change build_dir field to be an actual build dir) - #144162 (Debug impls for DropElaborators) - #144189 (Add non-regression test for #144168) - #144216 (Don't consider unstable fields always-inhabited) - #144229 (Miri subtree update) - #144230 (Option::as_slice: fix comment) - #144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jul 21, 2025
Rollup of 8 pull requests Successful merges: - #144144 (tests: Skip supported-crate-types test on musl hosts) - #144159 (opt-dist: change build_dir field to be an actual build dir) - #144162 (Debug impls for DropElaborators) - #144189 (Add non-regression test for #144168) - #144216 (Don't consider unstable fields always-inhabited) - #144229 (Miri subtree update) - #144230 (Option::as_slice: fix comment) - #144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 21, 2025
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Jul 21, 2025
…ler-errors Don't consider unstable fields always-inhabited This reverts the hack in rust-lang#133889 now that `Pin`'s field is no longer public. Fixes rust-lang#143468. r? ```@compiler-errors```
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Jul 21, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#144144 (tests: Skip supported-crate-types test on musl hosts) - rust-lang#144159 (opt-dist: change build_dir field to be an actual build dir) - rust-lang#144162 (Debug impls for DropElaborators) - rust-lang#144189 (Add non-regression test for rust-lang#144168) - rust-lang#144216 (Don't consider unstable fields always-inhabited) - rust-lang#144229 (Miri subtree update) - rust-lang#144230 (Option::as_slice: fix comment) - rust-lang#144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jul 22, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#144144 (tests: Skip supported-crate-types test on musl hosts) - rust-lang/rust#144159 (opt-dist: change build_dir field to be an actual build dir) - rust-lang/rust#144162 (Debug impls for DropElaborators) - rust-lang/rust#144189 (Add non-regression test for rust-lang/rust#144168) - rust-lang/rust#144216 (Don't consider unstable fields always-inhabited) - rust-lang/rust#144229 (Miri subtree update) - rust-lang/rust#144230 (Option::as_slice: fix comment) - rust-lang/rust#144235 (Fix run-make tests on musl hosts) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the hack in #133889 now that
Pin's field is no longer public.Fixes #143468.
r? @compiler-errors